Skip to content

Tpetra: Fix #4797 & fix #4789

James Willenbring requested to merge Fix-4797-3 into develop

Created by: mhoemmen

@trilinos/tpetra

This supersedes PR #4798.

Description

  • Deprecate Tpetra::MultiVector::getDualView method.
  • Add new Tpetra::Vector "offset view" constructor so that downstream code doesn't need this method any more.
  • Remove all use of this method from downstream Trilinos packages.
  • Document how to get the same functionality elsewhere.
  • Fix unrelated build warnings.

Motivation and Context

The deprecated method exposes an implementation detail of Tpetra::MultiVector and Tpetra::Vector, namely that they have a Kokkos::DualView inside. This hinders fixing outstanding issues like #364, and also hinders optimizations like #333.

Related Issues

How Has This Been Tested?

Fully downstream with GCC + OpenMP.

Merge request reports