Created by: mhoemmen
@trilinos/tpetra
This supersedes PR #4798.
Description
- Deprecate
Tpetra::MultiVector::getDualView
method. - Add new
Tpetra::Vector
"offset view" constructor so that downstream code doesn't need this method any more. - Remove all use of this method from downstream Trilinos packages.
- Document how to get the same functionality elsewhere.
- Fix unrelated build warnings.
Motivation and Context
The deprecated method exposes an implementation detail of Tpetra::MultiVector
and Tpetra::Vector
, namely that they have a Kokkos::DualView
inside. This hinders fixing outstanding issues like #364, and also hinders optimizations like #333.
Related Issues
- Closes #4797 (closed), #4789 (closed)
- Related to #333, #364
How Has This Been Tested?
Fully downstream with GCC + OpenMP.