Skip to content

Seacas fix off by one

James Willenbring requested to merge gsjaardema:seacas-fix-off-by-one into develop

Created by: gsjaardema



Fixing off-by-one errors in recent change from using strncpy to using copy_string there was a misunderstanding about how IOSS and exodus were using the "maximumNameLength" on an exodus file -- did it include trailing null or not (it doesn't). This is fixed.

Also fixed an off-by-one in the SUPES fortran/c interface routine.

The existing tests should have caught this issue, so will be looking at tests to see what they missed, but wanted to get this committed so clients are working again...

Motivation and Context

How Has This Been Tested?


  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports