Skip to content

EXODUS: Fix a few off-by-one in copy_string

James Willenbring requested to merge gsjaardema:seacas-exodus-copy-string into develop

Created by: gsjaardema

@trilinos/seacas

Description

Converted all strncpy to copy_string. Both should take the same length, but several uses of strncpy were passing in a length shortened by 1 and then explicitly adding the null at end. The automated conversion of strncpy to copy_string missed a few cases where the length needed to increased by 1. This causes no memory issues since not overrunning buffer; instead it was not using the last position.

Motivation and Context

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Merge request reports