Skip to content

GitLab

Closed
Opened by James Willenbring@jmwilleMaintainer

Kokkos_ENABLE_Debug_Bounds_Check=ON and KOKKOS_ENABLE_DEBUG=ON by default if Trilinos_ENABLE_DEBUG=ON

Created by: bartlettroscoe

CC: @trilinos/kokkos

Next Action Status

KOKKOS_ENABLE_DEBUG=ON is enabled in Trilinos_ENABLE_DEBUG=ON builds and in ATDM builds. New failures caused by this in ATDM builds is being addressed in #2471 (closed).

Description

Currently, enabling Trilinos_ENABLE_DEBUG=ON does not by default enable KOKKOS_ENABLE_DEBUG=ON or Kokkos_ENABLE_Debug_Bounds_Check=ON. This is a problem that means that none of the automated builds for Trilinos seem to be testing Trilinos with these enabled a shown by:

$ cd Trilinos/
$ find cmake/ctest/drivers/ -name "*.cmake" \
  -exec grep -nH Kokkos_ENABLE_Debug_Bounds_Check {} \;
... empty ...

This is a problem for ATDM because the ATDM builds of Trilinos are explicitly setting Kokkos_ENABLE_Debug_Bounds_Check=ON for debug builds and no other automated builds of Trilinos (including the CI and auto PR testing builds) ever test with this turned on. This means that all of auto PR, CI and other builds of Trilinos that pass with Trilinos_ENABLE_DEBUG=ON will still allow code to fail when KOKKOS_ENABLE_DEBUG=ON and Kokkos_ENABLE_Debug_Bounds_Check=ON are set.

Related Issues